Repository navigation
Conversation
The error report now lists the Java version, and the JDBC driver name and version for JDBC connections (or the DBI driver package and version for DBI connections). Fixes OHDSI#267
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #267
The SQL error report (
errorReportSql.txt) now includes the Java version and, as suggested in the issue comments, the driver version:java.lang.System.getProperty("java.version").DatabaseMetaData(for examplePostgreSQL JDBC Driver (42.7.3)).querySql()/executeSql()): the DBI driver package and its version (for exampleduckdb (1.5.6)).These lines appear after
Platform:in the system info section. Each lookup is wrapped intryCatch()and falls back toUnknown, so the report is still written when the connection is broken..createErrorReport()has a new optionalconnectionargument, and all five call sites (executeSql()twice,querySql(),renderTranslateQueryApplyBatched(), andquerySqlToAndromeda()) pass the connection. Nothing else changes, and NEWS.md is not touched.Example report section (Postgres):
Tests: the new
tests/testthat/test-errorReport.Rloops over the test servers and checks the report for both JDBC connections (Postgres) and DBI connections (SQLite, DuckDB). It also has one test with a plainduckdbDBI connection. I ran it against PostgreSQL 16 in Docker plus the local SQLite and DuckDB servers. It fails ondevelopand passes with this change.R CMD check --no-manual --ignore-vignettesgives Status: OK.