Execute DQ on Extension with Long format thresholds - #682
Open
MaximMoinat wants to merge 13 commits into
Open
Conversation
MaximMoinat
force-pushed
the
long-format-thresholds
branch
from
August 19, 2026 13:18
4edbfd4 to
f833979
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds function
executeDqChecksOnExtensionwhich takes check thresholds in long format and only executes on these tables/fields. See vignette for explanation and minimal usage example.Name of the function to be decided. The defining feature is that you can specify the thresholds in a long format, which makes it easier to define for custom/extension tables.
While this is a stand-alone function that uses the DQD machinery, the following small changes to DQD were needed. Behaviour should have remained the same.
isForeignKey.sqlrefactored to allow checking against non-CDM tables. Foreign key tables were hardcoded.runCheck.Rrefactoring to handle when check not found in threshold (in same logic as no rows found with enabled check)testthat/setup.Rmoved test threshold files to the testthat folder and read these withtest_path()