Improve atlas build - #2927
Merged
Merged
Conversation
…urce The results-viewer's WebR/shinylive runtime needs a full R + renv toolchain, which the build_plugins runner cannot provision — CI set SKIP_SHINYLIVE=1, so CI-built trex images shipped the viewer without its runtime (/atlas/plugins/results-viewer/shinylive/ absent, dead viewer). trex-notebook now publishes @ohdsi/results-viewer with the runtime folded into dist/ (built by its Dockerfile r-builder stage; OHDSI/trex-notebook#8). Switch the file: dep to the published package and drop the R build path here: build-atlas.sh loses the Rscript requirement and SKIP_SHINYLIVE, and CI builds one fewer sub-plugin from the submodule. postinstall staging is unchanged — it copies node_modules/@ohdsi/results-viewer/dist as before.
p-hoffmann
changed the title
p-hoffmann
marked this pull request as ready for review
July 21, 2026 00:57
p-hoffmann
requested review from
SantanM,
brandantck,
csafreen,
mwaiyee and
suwarnoong
as code owners
July 21, 2026 00:57
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Atlas build process to stop building the results-viewer sub-plugin from the trex-notebook submodule (and thus removes the R/shinylive build requirement), instead consuming @ohdsi/results-viewer as a prebuilt package from GitHub Packages.
Changes:
- Remove
results-viewerfrom the locally-built Atlas sub-plugin list inscripts/build-atlas.sh. - Update
plugins/atlasto depend on a published@ohdsi/results-viewerpackage version rather than afile:dependency. - Simplify the CI workflow by removing the
results-viewerbuild step (and theSKIP_SHINYLIVEworkaround) from the Docker build job.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scripts/build-atlas.sh | Drops the R-based results-viewer build path and builds only the remaining submodule-based sub-plugins. |
| plugins/atlas/package.json | Switches @ohdsi/results-viewer from a local file: dependency to a pinned prebuilt package version. |
| .github/workflows/docker-build-push.yaml | Removes results-viewer from the sub-plugin build loop and updates CI comments to reflect the new prebuilt approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.