[18.0][FIX] base_fontawesome: Keep style loading order#3634
Open
ypapouin wants to merge 1 commit into
Open
Conversation
To ensure that the overridden fontawesome style is perfectly replaced, we have to operate in group mode and force asset position using `after` [1] keyword. [1] https://www.odoo.com/documentation/18.0/developer/reference/frontend/assets.html#after
ypapouin
force-pushed
the
18.0-fix-assets-loading-order
branch
from
f665483 to
a308e23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When this module is installed, the
/web/static/src/webclient/icons.scssstylesheet is loaded before when it should be loaded after, as a consequence default weight for.fais 900 instead of 400.To ensure that the overridden fontawesome style is perfectly replaced, we have to operate in group mode and force asset position using
after[1] keyword.[1] https://www.odoo.com/documentation/18.0/developer/reference/frontend/assets.html#after
before:
after:
