Repository navigation
Put the window header in the title bar row - #23
Merged
Merged
Conversation
The header sat below the hidden title bar, so the window opened with an empty 32 point strip above a 40 point header, and the back button kept the 76 point inset meant for clearing the window buttons one row higher. The header now fills the title bar area, sized from the safe area, so the back button, title and gear line up with the window buttons.
|
@ReffWu is attempting to deploy a commit to the MagicAPI Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. This review ran on the open-source allowance, not this organization's plan, because the pull request author doesn't have an assigned seat. Waiting won't change this — ask an organization admin to assign them a seat, or add seats in Billing if every seat is already assigned, then retry. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Comment |
pulkitxm
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19. The window uses a hidden title bar, but the header was laid out below it. The window opened with a 32 point strip that held only the window buttons, then a 40 point header whose back button kept the 76 point inset meant for clearing those buttons one row higher. The back button looked detached, and the top of the window carried about 72 points of chrome.
The header now fills the title bar area, sized from the window's safe area inset instead of a fixed height, so it follows whatever title bar height the running macOS uses. The back button sits right after the window buttons, and the title and gear line up with them. Clicks still reach the header buttons. Nothing else in the layout changes; the content gains the 40 points the extra band used.
Validated with
swift-format lint --strict Sources/*.swift,python3 scripts/check.py policy, andmake build, plus a hit test on the back button and gear in the built window.