Potential fix for code scanning alert no. 13: Inefficient regular expression#53
Closed
NovasPlace wants to merge 1 commit into
Closed
Potential fix for code scanning alert no. 13: Inefficient regular expression#53NovasPlace wants to merge 1 commit into
NovasPlace wants to merge 1 commit into
Conversation
…ression Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/NovasPlace/CSM/security/code-scanning/13
The best fix is to remove nested/overlapping repetition ambiguity in
QUOTED_POSIX_PATH_PATTERNby ensuring each repeated unit is a single path segment that cannot include/.Concretely, in
src/redactor.tsline 109 region, replace:(?:\/[^"'\r\n]+)+with a safer equivalent:
(?:\/[^\/"'\r\n]+)+This preserves functionality (quoted absolute POSIX-like paths under the listed roots) while preventing the inner segment matcher from consuming
/, eliminating the exponential backtracking shape CodeQL reported. No new methods, imports, or dependencies are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.