Bump WolverineFx and WolverineFx.RuntimeCompilation - #2416
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps WolverineFx from 6.36.0 to 6.37.0 Bumps WolverineFx.RuntimeCompilation from 6.36.0 to 6.37.0 --- updated-dependencies: - dependency-name: WolverineFx dependency-version: 6.37.0 dependency-type: direct:production update-type: version-update:semver-minor - dependency-name: WolverineFx.RuntimeCompilation dependency-version: 6.37.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded by #2420. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated WolverineFx from 6.36.0 to 6.37.0.
Release notes
Sourced from WolverineFx's releases.
6.37.0
Eight issues, one of them breaking.
ServiceCapabilities.EventModelis now anEventModelSetDescriptorrather than a singleEventModelDescriptor(#4424). A host can legitimately assemble several Event Models — each store names its own throughStoreOptions.EventModelName, and a modular monolith registers an ancillary store per module — and the export used to fold them all into one named for the service, losing a model's name outright and reporting nothing.This is a compile break for anything reading that property, and the capabilities wire shape changes with it. A consumer that can only render one model asks
.Sole, or folds explicitly with.Collapse()and gets aModelCollapsehotspot recording what it lost. CritterWatch consumes this shape and has the equivalent fold still to follow.Everything else in the public surface is additive.
Event Modeling
FinishModelcarried a private copy of the cross-slice join; it is re-based onEventModelDescriptor.Links, so the pattern Wolverine derives and the arrow a viewer draws cannot disagree. A slice triggered by another slice's event throughTriggerType— not onlyCommandType— is now classified too.ReadsFromis split out ofReadModelTypes(#4419).[ReadModel]and[Entity]parameters are things a slice reads;IStorageAction<T>returns are what it produces. They shared one list, which meant the Automation input edge — Event → Read Model → ⚙ Command — could not be drawn at all.Origin(#4425). Wolverine registers two sources on theDerivedrung, so a disagreement between them used to render asDerived claims X; Derived claims Y, naming neither file. It now readsevent-model://wolverineagainstevent-model://wolverine-http.Native AOT
codegen writeemits its own[DynamicDependency]rooting (#4426). Every Native AOT application had to hand-write a rooting block covering the generated registry, every generated handler, every handler class, every message type, andMessageRouter<T>/EmptyMessageRouter<T>closed over each one. Codegen now emits anAotRootscompanion anchored by[ModuleInitializer]— an unconditional ILC root — so there is no app-side code at all. Verified by a realPublishAotbinary booting and dispatching with the hand-written roots deleted.Bug fixes
Envelope.Storedoes not survive persistence, so the acknowledgement fell back to the main store — the ancillary row survived, and the message was recovered, sent and handled again on every restart. Thanks to @raypet-visma for the diagnosis and the fix sketch._consumer.Close()is a synchronous P/Invoke that can block forever against a degraded broker, soIHost.StopAsyncnever completed — observed wedged 20+ minutes, past bothDrainTimeoutandShutdownTimeout. It now runs under the drain budget on a dedicated thread, and an abandoned teardown suppresses the consumerDisposerather than destroying a handle another thread still owns.OnExceptionreturningOutgoingMessagescompiles again (#4416). It failed code generation with "Frame chain is being re-arranged" while the same method on a middleware class worked. Thanks to @uniquelau for the report and for locating the exact divergence. The error-handling docs gained an example of using the hook to publish messages when the original message fails.Build & dependencies
codegen writeoutput is regenerated and aCICodegenDriftgate now guards it — meaningful only now that the emitted statement order is deterministic. Regenerating surfaced real staleness rather than the expected reordering: six orphaned handler files and four missing registry files.Commits viewable in compare view.
Updated WolverineFx.RuntimeCompilation from 6.36.0 to 6.37.0.
Release notes
Sourced from WolverineFx.RuntimeCompilation's releases.
6.37.0
Eight issues, one of them breaking.
ServiceCapabilities.EventModelis now anEventModelSetDescriptorrather than a singleEventModelDescriptor(#4424). A host can legitimately assemble several Event Models — each store names its own throughStoreOptions.EventModelName, and a modular monolith registers an ancillary store per module — and the export used to fold them all into one named for the service, losing a model's name outright and reporting nothing.This is a compile break for anything reading that property, and the capabilities wire shape changes with it. A consumer that can only render one model asks
.Sole, or folds explicitly with.Collapse()and gets aModelCollapsehotspot recording what it lost. CritterWatch consumes this shape and has the equivalent fold still to follow.Everything else in the public surface is additive.
Event Modeling
FinishModelcarried a private copy of the cross-slice join; it is re-based onEventModelDescriptor.Links, so the pattern Wolverine derives and the arrow a viewer draws cannot disagree. A slice triggered by another slice's event throughTriggerType— not onlyCommandType— is now classified too.ReadsFromis split out ofReadModelTypes(#4419).[ReadModel]and[Entity]parameters are things a slice reads;IStorageAction<T>returns are what it produces. They shared one list, which meant the Automation input edge — Event → Read Model → ⚙ Command — could not be drawn at all.Origin(#4425). Wolverine registers two sources on theDerivedrung, so a disagreement between them used to render asDerived claims X; Derived claims Y, naming neither file. It now readsevent-model://wolverineagainstevent-model://wolverine-http.Native AOT
codegen writeemits its own[DynamicDependency]rooting (#4426). Every Native AOT application had to hand-write a rooting block covering the generated registry, every generated handler, every handler class, every message type, andMessageRouter<T>/EmptyMessageRouter<T>closed over each one. Codegen now emits anAotRootscompanion anchored by[ModuleInitializer]— an unconditional ILC root — so there is no app-side code at all. Verified by a realPublishAotbinary booting and dispatching with the hand-written roots deleted.Bug fixes
Envelope.Storedoes not survive persistence, so the acknowledgement fell back to the main store — the ancillary row survived, and the message was recovered, sent and handled again on every restart. Thanks to @raypet-visma for the diagnosis and the fix sketch._consumer.Close()is a synchronous P/Invoke that can block forever against a degraded broker, soIHost.StopAsyncnever completed — observed wedged 20+ minutes, past bothDrainTimeoutandShutdownTimeout. It now runs under the drain budget on a dedicated thread, and an abandoned teardown suppresses the consumerDisposerather than destroying a handle another thread still owns.OnExceptionreturningOutgoingMessagescompiles again (#4416). It failed code generation with "Frame chain is being re-arranged" while the same method on a middleware class worked. Thanks to @uniquelau for the report and for locating the exact divergence. The error-handling docs gained an example of using the hook to publish messages when the original message fails.Build & dependencies
codegen writeoutput is regenerated and aCICodegenDriftgate now guards it — meaningful only now that the emitted statement order is deterministic. Regenerating surfaced real staleness rather than the expected reordering: six orphaned handler files and four missing registry files.Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)