python3Packages.pyfuse3: Fix cross-compilation - #524083
Merged
Merged
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 11-100
SuperSandro2000
added
the
6.topic: cross-compilation
Member
|
Do you think we can get this upstreamed? |
dotlambda
reviewed
May 27, 2026
| def pkg_config(pkg, cflags=True, ldflags=False, min_ver=None): | ||
| """Frontend to pkg-config""" | ||
|
|
||
| + PKG_CONFIG = os.environ.get('PKG_CONFIG', 'pkg-config').split() |
Member
There was a problem hiding this comment.
What's the .split() for? Isn't $PKG_CONFIG the path to the executable, which might actually contain spaces if the store path does?
Contributor
Author
There was a problem hiding this comment.
sometimes PKG_CONFIG can be set to more than just the binary name, including additional params. for subprocess we need to feed this as list
Contributor
Author
done |
Contributor
|
Can we get a nixpkgs review ? |
Contributor
Author
|
Contributor
|
Successfully created backport PR for |
github-actions
Bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding patch, otherwise cross-compilation, for example for riscv, will fail because the pkg-config name here will be different
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.