Skip to content

goofcord: 2.2.0 -> 2.2.1#516940

Open
Babakinha wants to merge 2 commits intoNixOS:masterfrom
Babakinha:goofcord-2.2.1
Open

goofcord: 2.2.0 -> 2.2.1#516940
Babakinha wants to merge 2 commits intoNixOS:masterfrom
Babakinha:goofcord-2.2.1

Conversation

@Babakinha
Copy link
Copy Markdown

@Babakinha Babakinha commented May 5, 2026 •
edited
Loading

Release: https://github.com/Milkshiift/GoofCord/releases/tag/v2.2.1
Diff: Milkshiift/GoofCord@v2.2.0...v2.2.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@nixpkgs-ci nixpkgs-ci Bot requested review from MiniHarinn and nyabinary May 5, 2026 16:51
@nixpkgs-ci nixpkgs-ci Bot added 8.has: package (update) This PR updates a package to a newer version 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle! labels May 5, 2026
@nixpkgs-ci nixpkgs-ci Bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label May 5, 2026
MiniHarinn
MiniHarinn suggested changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MiniHarinn MiniHarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, welcome to nixpkgs! Between 2.2.0 and 2.2.1 there are node deps changes, so you should also update the hashes in node-modules.nix.

@Babakinha
Copy link
Copy Markdown
Author

Babakinha commented May 6, 2026

Yes, i remember trying to do that, but getting the same hash.
I just tried it again and now i get a different hash, i was definitely doing something wrong..

Thx for letting me know.

@Babakinha Babakinha requested a review from MiniHarinn May 6, 2026 15:50
@MiniHarinn
Copy link
Copy Markdown
Contributor

MiniHarinn commented May 6, 2026

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 516940
Commit: e6e93ef65a420488ff0e0290b54cb516f0e15ffa (subsequent changes)
Merge: fb20ffa9f4882d99e50be6963b0ce69948e67735

Logs: https://github.com/MiniHarinn/nixpkgs-review-gha/actions/runs/25446701244

x86_64-linux

✅ 1 package built:
  • goofcord

aarch64-linux

✅ 1 package built:
  • goofcord

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

MiniHarinn
MiniHarinn approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@MiniHarinn MiniHarinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds fine, runs fine, and I can message my friend. LGTM!

@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nyabinary nyabinary Awaiting requested review from nyabinary

1 more reviewer

@MiniHarinn MiniHarinn MiniHarinn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Babakinha @MiniHarinn