python3Packages.zha: 1.1.2 -> 1.3.0#515610
Merged
dotlambda merged 9 commits intoNixOS:masterfrom May 6, 2026
Merged
Conversation
nixpkgs-ci
Bot
added
8.has: package (update)
Contributor
Author
|
Contributor
Author
|
Holy sh*t 53 out of 60 is SO much better than I thought I was gonna do... |
Contributor
Author
|
Well... zigpy-zboss hasn't had an update in 2 years so... best I can do is suppress the tests I guess... we shall see if that even works... |
Contributor
Author
|
dotlambda
reviewed
May 2, 2026
| "tests/application/test_startup.py" | ||
| "tests/application/test_zdo_requests.py" | ||
| "tests/application/test_zigpy_callbacks.py" | ||
| # This hasn't been updated in 2 years, and we're getting new failing tests. Best I can do for now is disable them. |
Member
There was a problem hiding this comment.
Maybe we should drop the package entirely?
Contributor
Author
There was a problem hiding this comment.
I was thinking exactly the same thing to be honest...
Contributor
Author
There was a problem hiding this comment.
@dotlambda oh I just realized you are the sole maintainer. Do you consent to the package being dropped?
Contributor
Author
There was a problem hiding this comment.
Also zigpy-cli or whatever its dependent was again.
Member
There was a problem hiding this comment.
We can drop zigpy-zboss once breaking changes are allowed again: #503391
SuperSandro2000
force-pushed
the
zigpy
branch
2 times, most recently
from
abe9d8b to
5e81ffc
Compare
nixpkgs-ci
Bot
added
10.rebuild-darwin: 0
Contributor
Author
|
@SuperSandro2000 thanks for dropping the mew commit for me, I hadnt felt like fixing that yet |
Notarin
force-pushed
the
zigpy
branch
2 times, most recently
from
b53971d to
f317319
Compare
Contributor
Author
|
I'm not really sure what's up with that test btw, can someone else take a look at that? |
dotlambda
reviewed
May 5, 2026
Member
|
Member
Yeah that's fine. |
dotlambda
changed the title
Member
|
Please don't rebase your branch if a simple force push does the job. It makes it easier to compare revisions. |
dotlambda
reviewed
May 6, 2026
| cryptography | ||
| frozendict | ||
| jsonschema | ||
| pyserial-asyncio-fast |
Contributor
Author
There was a problem hiding this comment.
Also remove from inputs.
This creates a build failure. Are you sure this suggestion is not erroneous?
Member
There was a problem hiding this comment.
Why would removing the other line saying pyserial-asyncio-fast, cause a build failure?
Contributor
Author
I rebased purely because I also wanted to get back up to date with upstream for merging purposes. I try to keep my PRs relatively up to date, and this was a situation where I decided to do it at the same time. I get what you mean though. |
SuperSandro2000
approved these changes
May 6, 2026
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
I deployed this to my HASS and observed no problems
nixpkgs-ci
Bot
added
the
12.approvals: 1
Co-authored-by: dotlambda <github@dotlambda.de>
Hasn't been updated in 2 yrs, so best I can do is disable these test files to keep the ball rolling...
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python3Packages.zigpy-znp: 0.14.3 -> 1.0.0
python3Packages.zigpy-zigate: 0.13.4 -> 0.14.0
python3Packages.zigpy-xbee: fixed failing build by disabling test_connect
python3Packages.zigpy: 1.2.2 -> 1.4.0
python3Packages.zha-quirks: 1.1.1 -> 1.2.0
python3Packages.zha: 1.1.2 -> 1.3.0
python3Packages.bellows: 0.49.0 -> 0.49.1
This was an attempt to resolve #514757 , but ended up being a bit of a yak shave. There is likely mistakes I have made as well as dependents I have missed that have been broken, but I think I have things generally covered, so we shall see.
closes #515206
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.