[24.11] OWNERS: simplify workflow/ci owners#416417
[24.11] OWNERS: simplify workflow/ci owners#416417wolfgangwalther merged 1 commit intoNixOS:release-24.11from
Conversation
The current setup causes the Security team and the other owners of .github/workflows to **not** be pinged for the check-format/codeowners-v2/nixpkgs-vet workflows. This was highly likely unintended when adding those additional rules, so removing them. Also, we have some owners looking after `workflows/`, but not `ci/` - and some the other way around. This doesn't make much sense to me, since both parts depend on each other very much. (cherry picked from commit b98e7bb)
github-actions
Bot
added
6.topic: continuous integration
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This report is automatically generated by the check-cherry-picks CI workflow.
Some of the commits in this PR have not been cherry-picked exactly and require the author's and reviewer's attention.
Please make sure to follow the backporting guidelines and cherry-pick with the -x flag. This requires changes to go to the unstable branches (master / staging) first, before backporting them.
Occasionally, it is not possible to cherry-pick exactly the same patch. This most frequently happens when resolving merge conflicts while cherry-picking or when updating minor versions of packages which have already advanced to the next major on unstable. If you need to merge this PR despite the warnings, please dismiss this review.
Warning
Difference between af4ff13 and original b98e7bb may warrant inspection.
Show diff
@@ Commit message
and some the other way around. This doesn't make much sense to me, since
both parts depend on each other very much.
+ (cherry picked from commit b98e7bb95a1e66d951a9c517cadb151694358bad)
+
## ci/OWNERS ##
@@
+ # Processing of this file is implemented in workflows/codeowners-v2.yml
# CI
- /.github/*_TEMPLATE* @SigmaSquadron
--/.github/actions @NixOS/Security @Mic92 @zowoq @infinisil @azuwis @wolfgangwalther
--/.github/workflows @NixOS/Security @Mic92 @zowoq @infinisil @azuwis @wolfgangwalther
--/.github/workflows/check-format.yml @infinisil @wolfgangwalther
--/.github/workflows/codeowners-v2.yml @infinisil @wolfgangwalther
--/.github/workflows/nixpkgs-vet.yml @infinisil @philiptaron @wolfgangwalther
--/ci @infinisil @philiptaron @NixOS/Security @wolfgangwalther
+-/.github/workflows @NixOS/Security @Mic92 @zowoq @infinisil
+-/.github/workflows/check-format.yml @infinisil
+-/.github/workflows/nixpkgs-vet.yml @infinisil @philiptaron
+-/.github/workflows/codeowners-v2.yml @infinisil
+-/ci @infinisil @philiptaron @NixOS/Security
+-/ci/OWNERS @infinisil @philiptaron
+/.github/actions @NixOS/Security @Mic92 @zowoq @infinisil @azuwis @wolfgangwalther @philiptaron
+/.github/workflows @NixOS/Security @Mic92 @zowoq @infinisil @azuwis @wolfgangwalther @philiptaron
+/ci @NixOS/Security @Mic92 @zowoq @infinisil @azuwis @wolfgangwalther @philiptaron
- /ci/OWNERS @infinisil @philiptaron
++/ci/OWNERS @infinisil @philiptaron
# Development support
+ /.editorconfig @Mic92 @zowoqHint: The full diffs are also available in the runner logs with slightly better highlighting.
github-actions
Bot
added
10.rebuild-darwin: 0
wolfgangwalther
dismissed
github-actions[bot]’s stale review
I resolved the conflict by replacing the ci OWNERS on 24.11 with those on master. They had not been updated on 24.11.
1 participant
Manual backport of #412688.