Skip to content

haskellPackages.yaml: build executables#416121

Merged
sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom
ncfavier:yaml-exe
Jul 1, 2025
Merged

haskellPackages.yaml: build executables#416121
sternenseemann merged 1 commit intoNixOS:haskell-updatesfrom
ncfavier:yaml-exe

Conversation

@ncfavier
Copy link
Copy Markdown
Member

@ncfavier ncfavier commented Jun 12, 2025

This package doesn't build its executables (json2yaml, yaml2json) by default, see snoyberg/yaml#194.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Jun 12, 2025
@github-actions github-actions Bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jun 12, 2025
wolfgangwalther
wolfgangwalther reviewed Jun 12, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to target a different branch due to rebuilds.

Comment thread pkgs/development/haskell-modules/configuration-common.nix Outdated
@ncfavier ncfavier changed the base branch from master to haskell-updates June 12, 2025 12:26
@nixpkgs-ci nixpkgs-ci Bot closed this Jun 12, 2025
@nixpkgs-ci nixpkgs-ci Bot reopened this Jun 12, 2025
@ncfavier
Copy link
Copy Markdown
Member Author

ncfavier commented Jun 12, 2025

Needs to target a different branch due to rebuilds.

Yeah, sorry, forgot how this works 😅

sternenseemann
sternenseemann reviewed Jun 16, 2025
View reviewed changes
Comment thread pkgs/development/haskell-modules/configuration-common.nix Outdated
@ncfavier
haskellPackages.yaml: build executables
e0e02c8 
This package doesn't build its executables (json2yaml, yaml2json) by default, see
snoyberg/yaml#194.
sternenseemann
sternenseemann approved these changes Jun 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to rebuilds we should either wait for the next haskell-updates iteration or merge into staging.

@ncfavier
Copy link
Copy Markdown
Member Author

ncfavier commented Jun 16, 2025

No rush.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 16, 2025
@github-actions github-actions Bot removed the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. label Jun 16, 2025
@sternenseemann sternenseemann merged commit a28e514 into NixOS:haskell-updates Jul 1, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther left review comments

@sternenseemann sternenseemann sternenseemann approved these changes

@maralorn maralorn Awaiting requested review from maralorn

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ncfavier @sternenseemann @wolfgangwalther @wegank