Skip to content

vivaldi: 7.4.3684.46 -> 7.4.3684.50#416058

Merged
nixpkgs-merge-bot[bot] merged 1 commit intoNixOS:masterfrom
wineee:vivaldi-7.4.3684.50
Jun 13, 2025
Merged

vivaldi: 7.4.3684.46 -> 7.4.3684.50#416058
nixpkgs-merge-bot[bot] merged 1 commit intoNixOS:masterfrom
wineee:vivaldi-7.4.3684.50

Conversation

@wineee
Copy link
Copy Markdown
Member

@wineee wineee commented Jun 12, 2025 •
edited
Loading

Things done

https://vivaldi.com/blog/desktop/minor-update-three-7-4/

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Nixpkgs 25.11 Release Notes (or backporting 24.11 and 25.05 Nixpkgs Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
  • NixOS 25.11 Release Notes (or backporting 24.11 and 25.05 NixOS Release notes)
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other contributing documentation in corresponding paths.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions Bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Jun 12, 2025
@nix-owners nix-owners Bot requested review from marcusramberg and max06 June 12, 2025 07:14
@ddogfoodd
Copy link
Copy Markdown
Contributor

ddogfoodd commented Jun 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 416058
Commit: 18ee421781c941832342b5be6d0c5ff0e1a56019

x86_64-linux

✅ 1 package built:
  • vivaldi

@ddogfoodd ddogfoodd added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jun 12, 2025
@ddogfoodd ddogfoodd added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. labels Jun 12, 2025
@ddogfoodd
Copy link
Copy Markdown
Contributor

ddogfoodd commented Jun 12, 2025

oh my bad just noticed the label for approvals says reputable people and I don't know how that is defined, so I shouldn't set it

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. labels Jun 13, 2025
@max06
Copy link
Copy Markdown
Contributor

max06 commented Jun 13, 2025

This update has now 3 approvals. What else is required? (Newbie here)

@wineee
Copy link
Copy Markdown
Member Author

wineee commented Jun 13, 2025

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot nixpkgs-merge-bot Bot merged commit fb3ea69 into NixOS:master Jun 13, 2025
23 of 25 checks passed
@nixpkgs-merge-bot
Copy link
Copy Markdown
Contributor

nixpkgs-merge-bot Bot commented Jun 13, 2025

Merge completed (#306934)

@wineee wineee deleted the vivaldi-7.4.3684.50 branch June 13, 2025 10:12
@max06
Copy link
Copy Markdown
Contributor

max06 commented Jun 13, 2025

Ohhh! 😆

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 13, 2025
Merged
1 task
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Jun 13, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci Bot commented Jun 13, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci Bot mentioned this pull request Jun 13, 2025
Merged
1 task
@github-actions github-actions Bot added the 8.has: port to stable This PR already has a backport to the stable release. label Jun 13, 2025
@wineee
Copy link
Copy Markdown
Member Author

wineee commented Jun 13, 2025

This update has now 3 approvals. What else is required? (Newbie here)

As a maintainer (declared in meta.maintainers), you also have the right to merge using nixpkgs-merge-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcusramberg marcusramberg Awaiting requested review from marcusramberg

3 more reviewers

@max06 max06 max06 approved these changes

@THShafi170 THShafi170 THShafi170 approved these changes

@ddogfoodd ddogfoodd ddogfoodd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wineee @ddogfoodd @max06 @THShafi170 @wegank