Skip to content

cargo-web: drop - #345866

Closed
ocfox wants to merge 1 commit into
NixOS:masterfrom
ocfox:cargo-web
Closed

cargo-web: drop#345866
ocfox wants to merge 1 commit into
NixOS:masterfrom
ocfox:cargo-web

Conversation

@ocfox

@ocfox ocfox commented Oct 2, 2024

Copy link
Copy Markdown
Member

Things done

Remove cargo-web, broken from 2024-06-13 and the upstream is unmaintained for 5 years.

cc @kevincox

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg Bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 2, 2024
@kevincox

kevincox commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

I have no personal objection and done use it any more (so at least should not be marked as a maintainer) however there is a PR to fix it open #345812. So if @myclevorname wants to adopt and fix the package I see no reason it needs to be removed. I am happy to help them get he PRs in.

@ocfox

ocfox commented Oct 2, 2024

Copy link
Copy Markdown
Member Author

nice one

@ocfox ocfox closed this Oct 2, 2024
@myclevorname

Copy link
Copy Markdown
Contributor

I will adopt cargo-web in a separate PR after my PR gets into Nixpkgs.

@ocfox
ocfox deleted the cargo-web branch October 2, 2024 11:35
@myclevorname myclevorname mentioned this pull request Oct 6, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants