Conversation
…897) #894's tests read the file-request exemption out of the source and check the wording; with `not is_file_request` taken back out of the gate's if the whole suite stayed green (6414 OK). Five tests drive irc_loop() with a paste - carried from the superseded #890 - and three fail without the exemption. Changelog notes inside #888's own entry for this and for #896's description fix, which had none; the public bullet names the new label. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AP6LSxkr4n9dMFNSNMogmW
This was referenced Sep 23, 2026
Collaborator
Author
|
Superseded by #908 (merged), which executes the same exemption through irc_loop - checked: with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #897. Follow-up to #894 and #896.
What was wrong
#894's tests read the
is_file_requestexemption out of irc.py's source, and check the mute wording and the queue-full notice. None of them runs a paste. Withnot is_file_requesttaken back out of the gate's ownif-What changed
tests/test_a_pasted_album_is_taken_through_the_real_loop.py(5), carried from the superseded A pasted list of requests is taken one by one, and the mute says what is true (#888) #890 and adapted to A pasted album is not a flood, and the mute notice tells the truth (#888) #894's code: drivesirc_loop()against a scripted server (the A third nick when both configured names are taken, and 437 is a refusal #789 harness) with a paste arriving as channel lines, the loop's threads recorded. Thirty file rows and fifteen!rarrows are all dispatched with no mute or ban; searches are still muted and then banned; rows during a search-earned mute are served and never escalate it; a ban still refuses them.Verified
🤖 Generated with Claude Code
https://claude.ai/code/session_01AP6LSxkr4n9dMFNSNMogmW