Skip to content

A pasted album is taken through the real irc_loop, not only on paper (#897) - #900

Closed
chchatzop wants to merge 1 commit into
mainfrom
fix/897-the-paste-is-executed
Closed

chchatzop wants to merge 1 commit into
mainfrom
fix/897-the-paste-is-executed

Conversation

@chchatzop

Copy link
Copy Markdown
Collaborator

Fixes #897. Follow-up to #894 and #896.

What was wrong

#894's tests read the is_file_request exemption out of irc.py's source, and check the mute wording and the queue-full notice. None of them runs a paste. With not is_file_request taken back out of the gate's own if -

if is_bot_command and not is_file_request and security.is_flooding(user):
  • the whole suite stayed green (6414 OK, checked on main in a separate worktree). So the behaviour the operator asked for - "bot should just add them to queue one by one as he requests" - had no test that would notice it going.

What changed

Verified

  • Three of the five fail with the exemption removed from the gate; the other two (searches still metered, a ban still refusing) are controls and pass both ways.
  • Full suite on current main: 6426 OK (18 skipped).

🤖 Generated with Claude Code

https://claude.ai/code/session_01AP6LSxkr4n9dMFNSNMogmW

…897)

#894's tests read the file-request exemption out of the source and check
the wording; with `not is_file_request` taken back out of the gate's if
the whole suite stayed green (6414 OK). Five tests drive irc_loop() with
a paste - carried from the superseded #890 - and three fail without the
exemption. Changelog notes inside #888's own entry for this and for #896's
description fix, which had none; the public bullet names the new label.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AP6LSxkr4n9dMFNSNMogmW
@chchatzop

Copy link
Copy Markdown
Collaborator Author

Superseded by #908 (merged), which executes the same exemption through irc_loop - checked: with not is_file_request removed from the gate on main, four of its six tests fail. Closing. One small thing this PR had that main still lacks: the public changelog never mentions #896's rename of the setting's label to Max commands per window.

@chchatzop chchatzop closed this Sep 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

After #894: MAX_REQUESTS is still described as counting file requests, and nothing executes the exemption

1 participant