refactor(eth): replace deprecated SignedIntValueEncoder with UintValu… - #2733
Open
expertdicer wants to merge 1 commit into
Open
refactor(eth): replace deprecated SignedIntValueEncoder with UintValu…#2733expertdicer wants to merge 1 commit into
expertdicer wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eEncoder
Abstract
IntKeyEncoder.Encodefunction panics if the inputmath.Intis nil or negative. #2491collections.IntValueEncoderused to delegate toIntKeyEncoder, which panics on negative or nilsdkmath.Intvalues. That was misleading for signed state (e.g. wei block deltas) and unsafe for callers that expected a general signed int encoder.This PR splits signed value encoding from unsigned fixed-width encoding:
IntValueEncodernow marshals signedsdkmath.Int, a newUintValueEncoderkeeps the existing 32-byte big-endian format for non-negative persisted state, andweiStoreis typed assdkmath.Uint.eth.SignedIntValueEncoderis removed in favor of the generic collections encoder.