fix: release build version ldflags - #2712
Open
onikonychev wants to merge 1 commit into
Open
Conversation
onikonychev
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the go build linker flags used by the release build script so that build-time version metadata is written into Nibiru’s in-tree Cosmos SDK fork (under lib/cosmos-sdk) instead of the upstream github.com/cosmos/cosmos-sdk import path.
Changes:
- Switch
-ldflags -X ...targets forversion.{Name,AppName,Version,Commit,BuildTags}togithub.com/NibiruChain/nibiru/v2/lib/cosmos-sdk/version. - Switch the
DBBackend-Xtarget togithub.com/NibiruChain/nibiru/v2/lib/cosmos-sdk/types(note: this introduces a link-time failure as written; see review comment).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest build returns empty for
nibid versionbecause of the modified build process