Skip to content

[Boolti-492] 공연 상세 탭 전환 시 WebView 재로딩 및 로그 과다 출력 개선 - #497

Merged
HamBP merged 11 commits into
developfrom
enhance/492
Jul 21, 2026
Merged

[Boolti-492] 공연 상세 탭 전환 시 WebView 재로딩 및 로그 과다 출력 개선#497
HamBP merged 11 commits into
developfrom
enhance/492

Conversation

@HamBP

@HamBP HamBP commented Apr 29, 2026

Copy link
Copy Markdown
Member

Issue

작업 내용

  • 공연 상세 탭 전환 시 webViewShowDetailScreen 스코프로 호이스팅해 탭 복귀 시 재로딩 방지
  • setRequestedFrameRate 로그가 초당 240번 출력되던 문제 개선

개선 전

KakaoTalk_20260430_043328231.mp4

개선 후

KakaoTalk_20260430_043335618.mp4

리뷰 포인트

  • redirectedInquiryUrl, intentToNavigateTo 상태는 ShowInfoTab 내부에 유지하고, WebView 인스턴스만 끌어올려 생명주기를 분리

@HamBP HamBP added this to the 1.15.0 milestone Apr 29, 2026
@HamBP HamBP added the enhancement New feature or request label Apr 29, 2026
@HamBP HamBP self-assigned this Apr 29, 2026
@HamBP
HamBP requested a review from mangbaam April 29, 2026 19:31
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

🟢 APK size: 90.99 MB (0.00 MB, 0.00%) vs develop — 거의 변화 없음

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

Test Results

 6 files   6 suites   0s ⏱️
 9 tests  9 ✅ 0 💤 0 ❌
10 runs  10 ✅ 0 💤 0 ❌

Results for commit e4aee45.

♻️ This comment has been updated with latest results.

@HamBP
HamBP marked this pull request as draft April 29, 2026 19:57
@mangbaam

Copy link
Copy Markdown
Member

이거 아직 draft?

@HamBP

HamBP commented Apr 29, 2026

Copy link
Copy Markdown
Member Author

답글이 안 달리넹
자체 코드 리뷰 돌렸는데 수정할 곳이 있어서 수정 중!

@HamBP
HamBP marked this pull request as ready for review May 4, 2026 12:23
@HamBP
HamBP marked this pull request as draft May 4, 2026 12:37
@HamBP
HamBP marked this pull request as ready for review May 4, 2026 12:56
HamBP and others added 2 commits July 20, 2026 15:20
# Conflicts:
#	presentation/src/main/java/com/nexters/boolti/presentation/screen/showdetail/ShowDetailScreen.kt
val uriHandler = LocalUriHandler.current
var redirectedInquiryUrl: String? by remember { mutableStateOf(null) }
var intentToNavigateTo: Intent? by remember { mutableStateOf(null) }
val webView = remember {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key 로 context 쓰는게 낫지 않으려나 싶네

@HamBP
HamBP merged commit fadb1fc into develop Jul 21, 2026
4 checks passed
@HamBP
HamBP deleted the enhance/492 branch July 21, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

기존 웹뷰 개선

2 participants