[Boolti-492] 공연 상세 탭 전환 시 WebView 재로딩 및 로그 과다 출력 개선 - #497
Merged
Conversation
|
🟢 APK size: 90.99 MB (0.00 MB, 0.00%) vs |
Test Results 6 files 6 suites 0s ⏱️ Results for commit e4aee45. ♻️ This comment has been updated with latest results. |
HamBP
marked this pull request as draft
April 29, 2026 19:57
Member
|
이거 아직 draft? |
Member
Author
|
답글이 안 달리넹 |
HamBP
marked this pull request as ready for review
May 4, 2026 12:23
HamBP
marked this pull request as draft
May 4, 2026 12:37
HamBP
marked this pull request as ready for review
May 4, 2026 12:56
# Conflicts: # presentation/src/main/java/com/nexters/boolti/presentation/screen/showdetail/ShowDetailScreen.kt
mangbaam
approved these changes
Jul 20, 2026
| val uriHandler = LocalUriHandler.current | ||
| var redirectedInquiryUrl: String? by remember { mutableStateOf(null) } | ||
| var intentToNavigateTo: Intent? by remember { mutableStateOf(null) } | ||
| val webView = remember { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
작업 내용
webView를ShowDetailScreen스코프로 호이스팅해 탭 복귀 시 재로딩 방지setRequestedFrameRate로그가 초당 240번 출력되던 문제 개선개선 전
KakaoTalk_20260430_043328231.mp4
개선 후
KakaoTalk_20260430_043335618.mp4
리뷰 포인트
redirectedInquiryUrl,intentToNavigateTo상태는ShowInfoTab내부에 유지하고, WebView 인스턴스만 끌어올려 생명주기를 분리