Skip to content

docs: direct campaign discounts to Campaigns App - #80

Merged
next-devin merged 2 commits into
mainfrom
campaign-docs-entry
Nov 2, 2026
Merged

next-devin merged 2 commits into
mainfrom
campaign-docs-entry

Conversation

@next-devin

Copy link
Copy Markdown
Contributor

The general Offers guide sent campaign builders to Storefront discount rules. Scope that guide to Storefront and Admin API use, and link campaign builders to Campaigns App Offers & Discounts. The campaign guide now explains that this is the setup used by the SDK and templates, without making a blanket claim about API compatibility.

Documentation only; no discount behavior or compatibility changes.

Validation: NEXT_TELEMETRY_DISABLED=1 npm run build passed, including developer-link audit, link validation (0 errors), capability checks and markup checks.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
nextcommerce-docs a93fdcd Commit Preview URL

Branch Preview URL
Nov 02 2026, 09:42 AM

Comment thread content/docs/features/offers/index.mdx Resolved
Comment thread content/docs/features/offers/index.mdx Resolved
Comment thread content/docs/features/offers/index.mdx Resolved
Comment thread content/docs/features/offers/index.mdx Resolved
@kilo-code-bot

kilo-code-bot Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Code Review Summary

Status: 1 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 1
Issue Details (click to expand)

SUGGESTION

File Line Issue
content/docs/features/offers/index.mdx 5 The revised lead says Offers apply to "your storefront" and the Admin API, but removes the prior marketing-funnel/Campaigns API coverage. The page no longer documents that store-level Offers and Coupons can apply to campaign carts, while content/changelog/2026-10-12-payments-campaigns-admin-api-storefront.mdx:32-34 documents shipping vouchers and Offers working on the Campaigns API. Preserve or explicitly scope that capability rather than silently narrowing the page.
Files Reviewed (2 files)
  • content/docs/features/offers/index.mdx - 1 issue
  • content/docs/apps/campaigns-app/campaigns-offers-and-discounts.mdx - 0 issues

Fix these issues in Kilo Cloud

Previous Review Summary (commit 56e4cb6)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 56e4cb6)

Status: 6 Issues Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 1
WARNING 3
SUGGESTION 2
Issue Details (click to expand)

CRITICAL

File Line Issue
content/docs/features/offers/index.mdx 17 Removing the Campaigns API from the Site Offers bullet deletes documented, working capability. The repo's own changelog (2026-10-12-payments-campaigns-admin-api-storefront.mdx:32-34) documents store-level shipping vouchers and offers working on the Campaigns API, so the page now asserts a limitation that does not exist.

WARNING

File Line Issue
content/docs/features/offers/index.mdx 5 New lead drops the marketing-funnel/Campaigns API coverage, leaving no page documenting that store Offers and Coupons apply to campaign carts. Inconsistent with marketing-attribution.mdx:7 and orders-reports.mdx:80.
content/docs/features/offers/index.mdx 9 "That is the pricing setup used by the Campaign Cart SDK" is an unqualified blanket claim about SDK behavior, contradicting the PR's own goal of avoiding blanket compatibility claims.
content/docs/apps/campaigns-app/campaigns-offers-and-discounts.mdx 11 Same blanket SDK pricing claim; contradicts the documented support for store-level Offers/Vouchers on the Campaigns API.

SUGGESTION

File Line Issue
content/docs/apps/campaigns-app/campaigns-offers-and-discounts.mdx 11 "The store-level Offers and Coupons guides" are referenced as plain text with no links, while the counterpart page links here.
content/docs/features/offers/index.mdx 5 "Storefront Offers" introduces a product name used nowhere else in the docs or UI, and collides with "Storefront" as the channel proper noun.
Files Reviewed (2 files)
  • content/docs/features/offers/index.mdx - 4 issues
  • content/docs/apps/campaigns-app/campaigns-offers-and-discounts.mdx - 2 issues

Fix these issues in Kilo Cloud


Reviewed by minimax-m3 · Input: 43.5K · Output: 3.1K · Cached: 411K

@next-devin
next-devin merged commit 3a5b6d3 into main Nov 2, 2026
4 checks passed
@next-devin
next-devin deleted the campaign-docs-entry branch November 2, 2026 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant