feat(core): introduce GraphQL importer - #233
Open
ostridm wants to merge 2 commits into
Open
Conversation
|
Code Climate has analyzed commit 585f7d2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 97.1% (50% is the threshold). This pull request will bring the total coverage in the repository to 92.2% (0.1% change). View more on Code Climate. |
ostridm
marked this pull request as draft
March 28, 2024 09:31
ostridm
force-pushed
the
feat_#232/introduce-graphql-importer
branch
2 times, most recently
from
March 28, 2024 13:30
1d686be to
3c18b91
Compare
ostridm
force-pushed
the
feat_#232/introduce-graphql-importer
branch
from
March 28, 2024 13:31
3c18b91 to
4d8c69c
Compare
ostridm
marked this pull request as ready for review
March 28, 2024 13:38
derevnjuk
reviewed
Aug 21, 2024
Comment on lines
+1
to
+3
| export const isArrayOfStrings = (data: unknown) => !!data && Array.isArray(data) | ||
| ? data.every(item => typeof item === 'string') | ||
| : false; |
Member
There was a problem hiding this comment.
Suggested change
| export const isArrayOfStrings = (data: unknown) => !!data && Array.isArray(data) | |
| ? data.every(item => typeof item === 'string') | |
| : false; | |
| export const isArrayOfStrings = <T extends string>(data: unknown): data is T[] => Array.isArray(data) && data.every(item => typeof item === 'string'); |
Member
There was a problem hiding this comment.
This utility func is only used once. Do we really need it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #232