Repository navigation
FE-1: Consolidate duplicate frontend tests and review lib/stellar.ts … - #1512
Merged
Ehonrie merged 1 commit intoOct 22, 2026
Merged
Conversation
…& lib/config.ts (Netwalls#1510) - Merge unique test cases from f105-f108 extra test files into main test files: - DisputeModal: added 'builds dispute_resolution against market contract address' test - MarketStatusBadge: merged cancel reason badge tests (Draw, NoContest, AdminCancelled) - ClaimButton: merged dispute window blocking tests from resolution test file - TransactionStatusModal: f105-f108 tests fully covered by existing a11y + main tests - Add cancelReason prop to MarketStatusBadge component for distinct cancel badges - Delete the four extra test files: DisputeModal.f105-f108.test.tsx, MarketStatusBadge.f105-f108.test.tsx, TransactionStatusModal.f105-f108.test.tsx, ClaimButton.resolution.test.tsx - Review lib/stellar.ts and lib/config.ts: no duplicated or conflicting logic found. Config exports are centralized in config.ts, re-exported by stellar.ts. Timeout constants are appropriately scoped (TX_TIMEOUT_SECONDS for tx validity, TX_TIMEOUT_MS for polling). RPC server creation goes through centralized rpcServerOptions() with allowHttpForRpc validation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…& lib/config.ts (#1510)
Closes #1510
Closes #1511