Refactor Module.hs DFS logic - #190
Open
langfield wants to merge 9 commits into
Open
Conversation
langfield
force-pushed
the
langfield/module-refactor-redux
branch
8 times, most recently
from
March 26, 2023 12:33
bb5db53 to
91d3c08
Compare
Contributor
Author
|
A test like this has been written in #153. Thus the merge base should be changed. |
langfield
force-pushed
the
langfield/module-refactor-redux
branch
2 times, most recently
from
March 28, 2023 15:36
bb5db53 to
1db64b9
Compare
Minor refactoring of `Module.hs`
* `m_prog` -> `m_instrs` * `branchesByCallStackAndIfPc` -> `ifThenElseOutcomes` * `IfThenElseBranchMap` -> `IfThenElseOutcomeMap`
* Don't use explicit import lists for qualified imports * Refactor some docstrings * Rearrange functions in `Module.hs`
* Replace `visitArcs` with `visitArc` * Remove `visitLoop` and `visitLinear` and `extractPlainBuilder`. * Make `gatherModules` return `ModuleL [Module]`
langfield
force-pushed
the
langfield/module-refactor-redux
branch
from
March 29, 2023 14:29
1db64b9 to
cd01fff
Compare
Contributor
Author
|
DO NOT MERGE! |
langfield
force-pushed
the
langfield/module-refactor-redux
branch
6 times, most recently
from
March 30, 2023 12:19
fcf7e87 to
35dcf11
Compare
This commit restructures the control flow of the `visit` function in `Module.hs`, reducing the number of cases. * Remove `IfThenElseOutcomeMap` from `VertexContext` in `Module.hs` * Rename some variables in `visit` function in `Module.hs` * Use `&&` instead of `,` in guard within `Module.hs`
* Rename `acc` -> `insts` in `visit` * Rename `test` -> `arcCond'`
* Make `visitArcs` unary.
Rename some stuff: * `preOfPrevVertex` -> `pre`
langfield
force-pushed
the
langfield/module-refactor-redux
branch
from
March 30, 2023 12:43
35dcf11 to
c3e9bef
Compare
Change structure of sources: * `(Function, ScopedName, FuncSpec)` -> `(ScopedFunction, FuncSpec)` We also get rid of `gatherModules`, replaced with `gatherModulesForF`, which is only for a single function. * Remove `Module/Runner.hs` from `horus-check.cabal`
Contributor
Author
|
DO NOT MERGE! 💢 ☠️ |
langfield
force-pushed
the
langfield/module-refactor-redux
branch
from
March 30, 2023 15:01
c3e9bef to
2cc3ee4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're doing DFS, so let's try to make it look more like a standard DFS implementation. This PR removes the entire
ModuleLfree monad and eDSL.