implement comment injections - #183
Open
Ferinko wants to merge 12 commits into
Open
Conversation
Ferinko
force-pushed
the
ferinko/annotate_smts
branch
2 times, most recently
from
March 1, 2023 00:46
4a1095e to
c5f0571
Compare
Ferinko
force-pushed
the
ferinko/checkpoint_gone
branch
from
March 1, 2023 11:10
0966f3d to
e490654
Compare
Ferinko
force-pushed
the
ferinko/checkpoint_gone
branch
from
March 10, 2023 10:16
5eaa318 to
7b81e67
Compare
langfield
force-pushed
the
ferinko/checkpoint_gone
branch
from
March 10, 2023 13:31
7b81e67 to
466b9fd
Compare
In this commit, we add a function `userAnnotatedSources` which replaces `isStandardSource`. It generates a list of all the user annotated ScopedFunctions. This list is used to filter modules for solving. This requires a slight refactor within `FunctionAnalysis.hs`. * Add `extern_remove_dirty` test. The basic idea is this: 1. Find all wrapper functions. 2. Compute their respective set of reachable functions. 3. Mark them all as 'don't check' unless they are referenced from a different source as well.
Ferinko
force-pushed
the
ferinko/annotate_smts
branch
2 times, most recently
from
March 27, 2023 18:52
8e8119e to
76ac907
Compare
Don't verify `@external`-generated wrapper functions
* Use `ssh-agent` to clone with specific private key * Set `0o400` permissions on private key file * Add `mathsat` to list of solvers used in tests
Add mathsat installation to Github actions workflow
Cairo semantics comments
…ted-specs Add FAQ about commenting-out annotations
…eadme-additions Add `README.md` section on details of `CairoSemanticsL`
langfield
force-pushed
the
ferinko/annotate_smts
branch
from
March 28, 2023 15:41
76ac907 to
f41b3c6
Compare
langfield
reviewed
Mar 28, 2023
langfield
left a comment
langfield
left a comment
Contributor
There was a problem hiding this comment.
I'm in the process of reviewing this. It adds a lot of code.
Comment on lines
+85
to
+87
| isOptimising :: Vertex -> Bool | ||
| isOptimising = isJust . v_preCheckedF | ||
|
|
Contributor
There was a problem hiding this comment.
Duplicates isPreCheckingVertex (sorry about the name churn).
langfield
force-pushed
the
master
branch
2 times, most recently
from
March 31, 2023 15:01
9f9928b to
3397b7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements: