Repository navigation
Preserve dependency schema ZIP order in cached codegen - #980
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
iuliiasobolevska
requested review from
asibross,
iparadiso,
jjacobs44,
kilink,
kzwang,
paulbakker and
srinivasankavitha
as code owners
October 6, 2026 22:22
jiholee17
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #979 made
generateJavacache safe but changed dependency-jar schema parsing from ZIP entry order to entry-name order.That can reorder generated fields and positional constructor parameters compared with
8.7.0.Restore ZIP entry order in
CodeGenand add the schema entry sequence as a Gradle task input.Gradle can still reuse cached output when the sequence matches, while a jar repacked in a different order gets a different cache key because its generated output can differ.
The existing cache keys for filesystem and dependency-jar path order remain in place.
Validation
SchemaMergingTestverifies field and constructor parameter order for both ZIP sequences.GenerateJavaTaskBuildCacheTestverifies that a reordered jar executes generation, restoring the original sequence retrieves cached output and project-produced jars work under the configuration cache.validatePluginsandgit diff --checkpassed on Gradle 9.4.1.