Repository navigation
Restore generate-time dependency type mapping merges - #977
Merged
iuliiasobolevska merged 1 commit intoOct 6, 2026
Merged
Conversation
iuliiasobolevska
requested review from
asibross,
iparadiso,
jjacobs44,
kilink,
kzwang and
srinivasankavitha
as code owners
September 30, 2026 04:03
iuliiasobolevska
force-pushed
the
codex/backlog-24-typemappings-merge-timing
branch
from
September 30, 2026 17:37
7d63b06 to
4cdf01a
Compare
jiholee17
approved these changes
Oct 6, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
iuliiasobolevska
force-pushed
the
codex/backlog-24-typemappings-merge-timing
branch
from
October 6, 2026 21:31
4cdf01a to
40662f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #968 moved dependency-jar type-mapping merges into
CodeGenconstruction. Embedders that replaceconfig.typeMappingbetween construction andgenerate()can therefore lose jar mappings and generate a type that should be mapped.This change reads dependency mappings during construction but merges them into
config.typeMappingatgenerate()time, matching 8.7.0 behavior. Caller mappings still override jar mappings, earlier jars retain precedence over later jars, and repeatedgenerate()calls remain idempotent.Validation
:graphql-dgs-codegen-core:formatKotlinandgit diff --checkpassed.