Skip to content

Restore generate-time dependency type mapping merges - #977

Merged
iuliiasobolevska merged 1 commit into
masterfrom
codex/backlog-24-typemappings-merge-timing
Oct 6, 2026
Merged

iuliiasobolevska merged 1 commit into
masterfrom
codex/backlog-24-typemappings-merge-timing

Conversation

@iuliiasobolevska

Copy link
Copy Markdown
Collaborator

Summary

PR #968 moved dependency-jar type-mapping merges into CodeGen construction. Embedders that replace config.typeMapping between construction and generate() can therefore lose jar mappings and generate a type that should be mapped.

This change reads dependency mappings during construction but merges them into config.typeMapping at generate() time, matching 8.7.0 behavior. Caller mappings still override jar mappings, earlier jars retain precedence over later jars, and repeated generate() calls remain idempotent.

Validation

  • Four focused core type-mapping tests passed on JDK 17 with the in-process Kotlin compiler. They cover post-construction config changes, repeated generation, earlier-jar precedence, dependency mapping, and caller override behavior.
  • :graphql-dgs-codegen-core:formatKotlin and git diff --check passed.

@iuliiasobolevska iuliiasobolevska added the bug Something isn't working label Sep 30, 2026
@iuliiasobolevska iuliiasobolevska added the bug Something isn't working label Sep 30, 2026
@iuliiasobolevska
iuliiasobolevska force-pushed the codex/backlog-24-typemappings-merge-timing branch from 7d63b06 to 4cdf01a Compare September 30, 2026 17:37
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@iuliiasobolevska
iuliiasobolevska force-pushed the codex/backlog-24-typemappings-merge-timing branch from 4cdf01a to 40662f4 Compare October 6, 2026 21:31
@iuliiasobolevska
iuliiasobolevska merged commit beb25a5 into master Oct 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants