Repository navigation
Allow case-only generated paths on case-sensitive filesystems - #975
Merged
iuliiasobolevska merged 1 commit intoOct 6, 2026
Merged
Conversation
iuliiasobolevska
requested review from
paulbakker and
srinivasankavitha
as code owners
September 30, 2026 03:56
iuliiasobolevska
requested review from
asibross,
iparadiso,
jjacobs44,
kilink and
kzwang
as code owners
September 30, 2026 03:56
iuliiasobolevska
force-pushed
the
codex/case-collision-check-only-when-needed
branch
from
September 30, 2026 17:43
02d4161 to
d957f62
Compare
jiholee17
reviewed
Oct 6, 2026
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
iuliiasobolevska
force-pushed
the
codex/case-collision-check-only-when-needed
branch
from
October 6, 2026 21:16
d957f62 to
3de611f
Compare
jiholee17
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Generated sources whose paths differ only by case worked on case-sensitive filesystems in 8.7.0. The parallel writer added an unconditional case-folded collision check, so those schemas now fail before writing. This change probes the output filesystem only when a case-folded collision exists and rejects the collision only if the filesystem treats the two spellings as the same file.
Exact-path duplicates retain their existing last-wins behavior. The probe is removed in
finally, and the existing error message is preserved on case-insensitive filesystems.Validation
:graphql-dgs-codegen-core:test --tests com.netflix.graphql.dgs.codegen.ParallelFileWritingTestpassed on JDK 17 with the in-process Kotlin compiler.:graphql-dgs-codegen-core:formatKotlinandgit diff --checkpassed.