Use m for the snf matrix argument - #2475
Draft
HereAround wants to merge 1 commit into
Draft
Conversation
Align the documented and implementation argument name for snf with the matrix naming convention. Co-authored-by: Codex <codex@openai.com>
HereAround
added
breaking
release notes: not needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2475 +/- ##
==========================================
- Coverage 88.22% 88.22% -0.01%
==========================================
Files 131 131
Lines 33257 33257
==========================================
- Hits 29341 29340 -1
- Misses 3916 3917 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isolates the
snf(A::MatElem)tosnf(m::MatElem)argument rename from #2474.The printed method signature is currently captured by an Oscar book example, so this PR is intentionally left as a draft for the next breaking release, when the corresponding book output can be updated.
Co-authored-by: Codex codex@openai.com
cc @lgoettgens