Skip to content

Allow multiple layers to be specified for "multiplier_layer" - #319

Merged
ppinchuk merged 11 commits into
mainfrom
pp/multiple_mult_layers
Aug 7, 2026
Merged

Allow multiple layers to be specified for "multiplier_layer"#319
ppinchuk merged 11 commits into
mainfrom
pp/multiple_mult_layers

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

This gives maximal flexibility for users to apply chains of masks, and also opens the pathway for spatial voltage/polarity/row multipliers

@ppinchuk ppinchuk self-assigned this Aug 6, 2026
Copilot AI lite review requested due to automatic review settings August 6, 2026 19:31
@ppinchuk ppinchuk added the enhancement Update to logic or general code improvements label Aug 6, 2026
@ppinchuk
ppinchuk requested a review from castelao as a code owner August 6, 2026 19:31
@ppinchuk ppinchuk added p-high Priority: high topic-python-cli Issues/pull requests related to python CLI labels Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Suppressed comments (2)

revrt/utilities/parsing.py:53

  • This returns any iterable's contents without verifying that they are strings. For example, normalize_str_list_input(["layer", 1], "layers") succeeds even though the function's contract says it raises for an iterable containing non-strings; raw tracked-layer inputs can then fail later during layer lookup with a less actionable error. Materialize the iterable and validate every item here.
    return list(value)

docs/source/guides/routing_layers.md:162

  • Use “a list” rather than “an list.”
``"multiplier_layer"`` may be a string or an list. For a list, the

Comment thread crates/revrt/src/cost/components.rs
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.10%. Comparing base (13f3363) to head (6a6319d).

Files with missing lines Patch % Lines
revrt/routing/base.py 86.66% 1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (92.30%) is below the target coverage (93.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
- Coverage   95.13%   95.10%   -0.04%     
==========================================
  Files          29       29              
  Lines        3744     3759      +15     
  Branches      477      482       +5     
==========================================
+ Hits         3562     3575      +13     
- Misses        105      106       +1     
- Partials       77       78       +1     
Flag Coverage Δ
unittests 95.10% <92.30%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk
ppinchuk merged commit f311ee4 into main Aug 7, 2026
26 checks passed
@ppinchuk
ppinchuk deleted the pp/multiple_mult_layers branch August 7, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-high Priority: high topic-python-cli Issues/pull requests related to python CLI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants