Allow multiple layers to be specified for "multiplier_layer" - #319
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
revrt/utilities/parsing.py:53
- This returns any iterable's contents without verifying that they are strings. For example,
normalize_str_list_input(["layer", 1], "layers")succeeds even though the function's contract says it raises for an iterable containing non-strings; raw tracked-layer inputs can then fail later during layer lookup with a less actionable error. Materialize the iterable and validate every item here.
return list(value)
docs/source/guides/routing_layers.md:162
- Use “a list” rather than “an list.”
``"multiplier_layer"`` may be a string or an list. For a list, the
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (92.30%) is below the target coverage (93.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #319 +/- ##
==========================================
- Coverage 95.13% 95.10% -0.04%
==========================================
Files 29 29
Lines 3744 3759 +15
Branches 477 482 +5
==========================================
+ Hits 3562 3575 +13
- Misses 105 106 +1
- Partials 77 78 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This gives maximal flexibility for users to apply chains of masks, and also opens the pathway for spatial voltage/polarity/row multipliers