Skip to content

Minor extraction updates - #523

Merged
ppinchuk merged 6 commits into
mainfrom
pp/minor_fix
Aug 7, 2026
Merged

Minor extraction updates#523
ppinchuk merged 6 commits into
mainfrom
pp/minor_fix

Conversation

@ppinchuk

@ppinchuk ppinchuk commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Forward some attributes into outputs for better extraction monitoring

@ppinchuk ppinchuk self-assigned this Aug 6, 2026
@ppinchuk
ppinchuk requested a review from castelao as a code owner August 6, 2026 21:39
Copilot AI lite review requested due to automatic review settings August 6, 2026 21:39
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python labels Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Forward additional extraction/conversion attributes into document output metadata to improve monitoring and observability.

Changes:

  • Add several extraction/conversion-related fields to compiled document info output.
  • Track and persist num_features_extracted during ordinance parsing flows.
  • Treat OpenAI APIConnectionError as retryable in GPT calls.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
compass/services/threaded.py Adds more doc.attrs fields into the compiled doc info output payload for monitoring.
compass/services/openai.py Expands retryable OpenAI exception set to include connection errors.
compass/plugin/ordinance.py Computes and stores extracted feature counts in extraction_context.attrs during parsing.

Comment thread compass/services/openai.py
Comment thread compass/services/threaded.py
Comment thread compass/services/threaded.py
Comment thread compass/services/threaded.py
Comment thread compass/services/threaded.py
Comment thread compass/plugin/ordinance.py
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.78%. Comparing base (77e7a53) to head (1bc8636).

Files with missing lines Patch % Lines
compass/plugin/ordinance.py 0.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
- Coverage   63.82%   63.78%   -0.05%     
==========================================
  Files          78       78              
  Lines        7437     7445       +8     
  Branches      755      755              
==========================================
+ Hits         4747     4749       +2     
- Misses       2529     2536       +7     
+ Partials      161      160       -1     
Flag Coverage Δ
unittests 63.78% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk
ppinchuk merged commit b14fe34 into main Aug 7, 2026
22 checks passed
@ppinchuk
ppinchuk deleted the pp/minor_fix branch August 7, 2026 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Update to logic or general code improvements p-medium Priority: medium topic-python-general Issues/pull requests related to python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants