feat(nvcf-cli): support LLM request priority - #1312
Conversation
Add create, update, clear, and inspect support for function-level LLM request priority. Preserve explicit priority zero and document replacement semantics. Relates to NVIDIA#183
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe CLI now supports default and per-account LLM request priorities for function creation and updates. Client models serialize and decode these settings. Validation enforces priority formats, duplicate detection, required defaults, and the 64-account limit. Function details display priorities deterministically. ChangesLLM request priority configuration
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to This change adds configurable LLM request-priority options for function creation and updates; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant FunctionCommand
participant NVCFClient
participant FunctionAPI
FunctionCommand->>NVCFClient: Build request with LLM priority configuration
NVCFClient->>FunctionAPI: Create or update function
FunctionAPI-->>NVCFClient: Return configured function data
NVCFClient-->>FunctionCommand: Display decoded priority settings
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 3.92% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 51 functions across 5 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
TL;DR
Add
nvcf-cli function createandfunction updatesupport for function-level LLM request priority, including default and per-account priority configuration, input-file overrides and clearing, request serialization, validation, output, tests, and user documentation.Additional Details
--llm-default-priorityand repeatable--llm-per-account-priority <nca-id>:<priority>flags to function create and update.0, require a default when per-account overrides are configured, reject invalid or duplicate overrides, and enforce the 64-account limit.--input-fileconfiguration without modifying omitted fields; use an emptyllmInvocationConfigobject in an update input file to clear priority.Checklist
Summary by CodeRabbit
New Features
Documentation
Tests