[API] Refactor UserInputEventData into UserInputEvent, add validation for uniqueness of event type - #512
Open
ArielG-NV wants to merge 3 commits into
Open
[API] Refactor UserInputEventData into UserInputEvent, add validation for uniqueness of event type#512ArielG-NV wants to merge 3 commits into
UserInputEventData into UserInputEvent, add validation for uniqueness of event type#512ArielG-NV wants to merge 3 commits into
Conversation
Remove UserInputEventData infavor for UserInputEvent with validation that the class-type is unique
UserInputEventData into UserInputEvent, add validation for uniqueness of event
UserInputEventData into UserInputEvent, add validation for uniqueness of event UserInputEventData into UserInputEvent, add validation for uniqueness of event type
Contributor
Greptile SummaryThe PR replaces wrapped
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
B[Browser or client input] --> C[Concrete UserInputEvent with timestamp]
C --> E[EventBuffer]
E --> U[UI event routing]
E --> M[Model session step]
C --> L{Close or reset event?}
L -->|Close| S[Stop session]
L -->|Reset| R[Reset session generation]
Reviews (2): Last reviewed commit: "pre commit" | Re-trigger Greptile |
Collaborator
Author
|
/ok to test 5aa15a9 |
Collaborator
Author
|
/ok to test 19b47c6 |
ArielG-NV
enabled auto-merge
August 25, 2026 20:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #501
Goal: clean up
UserInputEventand shimUserInputEventDataChanges:
UserInputEventDatain-favor forUserInputEventUserInputEventclass-type is unique