Fix flaky accelerated HNSW gaps test - #2709
Open
viclafargue wants to merge 3 commits into
Open
viclafargue wants to merge 3 commits into
viclafargue wants to merge 3 commits into
Conversation
viclafargue
added
bug
imotov
approved these changes
Oct 3, 2026
imotov
left a comment
imotov
left a comment
Contributor
There was a problem hiding this comment.
Left a suggestion to relax the failing part instead of removing it completely. Otherwise LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2551.
The gaps test required the search to return the exact closest K documents. HNSW search can return a nearby document just outside that set. With the seed from #2551, the test sometimes requested five results and rejected document 858 because it was sixth closest.
This PR updates the test in the following way :