Skip to content

Fix cuvs build due to rmm and cuCollections api changes - #2504

Merged
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
jcrist:fix-bloom-filter-policy
Aug 26, 2026
Merged

Fix cuvs build due to rmm and cuCollections api changes#2504
rapids-bot[bot] merged 5 commits into
NVIDIA:mainfrom
jcrist:fix-bloom-filter-policy

Conversation

@jcrist

@jcrist jcrist commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

rapids-cmake just bumped the commit used for cuCollections in builds, leading to cuvs build failures.

Here we fix usage of cuco::default_filter_policy that were changed in NVIDIA/cuCollections#827.

Also fixes some fallout from rapidsai/rmm#2527, merging in #2503 (as well as a few small fixups).

Closes #2503.

betatim and others added 3 commits August 25, 2026 15:24
@betatim
Fix init of device_scalars
3259779 
Zeroed with a device memset. The device_scalar(value, stream) ctor would copy
from a host temporary that dies before the copy is guaranteed to have read it.
@betatim
Fix value init
cef1dc0 
Unrelated but same type of bug (found by AI).
@jcrist
Use cuco::bloom_filter_policy
f088c26
@jcrist
jcrist requested a review from a team as a code owner August 25, 2026 15:09
@jcrist

jcrist commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

For some reason local builds are failing for me in some raft compilation errors that we haven't seen in CI. This is on a clean fork and a conda environment built from conda/environments/all_cuda-129_arch-x86_64.yaml, so I'm not exactly sure what's going wrong. Hopefully things pass fine in CI.

@jcrist

jcrist commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Hmmm, ok, also seeing the same failures here. At least I know it's not just my env then!

Looks like some other upstream change has also broken things, beyond just the cuco bump.

@jcrist

jcrist commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Ah, it's rapidsai/rmm#2527, which broke some code in raft.

@wence-

wence- commented Aug 25, 2026

Copy link
Copy Markdown

Ah, it's rapidsai/rmm#2527, which broke some code in raft.

Just FWIW, that code in raft was always wrong, sorry :(

@jcrist

jcrist commented Aug 25, 2026

Copy link
Copy Markdown
Member Author

Build failures due to raft should be fixed by NVIDIA/raft#3123

@jcrist

jcrist commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

I've folded in the changes from #2503 as well, since both PRs will be needed to fix the cuvs builds. I also had to push a small fixup there to handle a few missed cases.

@jcrist jcrist changed the title Use cuco::bloom_filter_policy Fix cuvs build due to rmm and cuCollections api changes Aug 26, 2026
@divyegala divyegala added bug Something isn't working non-breaking Introduces a non-breaking change labels Aug 26, 2026
@betatim betatim mentioned this pull request Aug 26, 2026
Closed
@jameslamb

jameslamb commented Aug 26, 2026

Copy link
Copy Markdown
Member

/merge

@rapids-bot
rapids-bot Bot merged commit 14d9ef8 into NVIDIA:main Aug 26, 2026
170 of 173 checks passed
@jcrist
jcrist deleted the fix-bloom-filter-policy branch August 26, 2026 15:43
@csadorf csadorf mentioned this pull request Aug 26, 2026
Open
18 of 19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@divyegala divyegala divyegala approved these changes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jcrist @wence- @jameslamb @divyegala @betatim