Remove single file secondary_filters_byte_ranges API - #23800
Draft
qbacpey wants to merge 4 commits into
Draft
Conversation
…bloom filter` and `dict filter` API, update Java, Python, and examples related to it
qbacpey
added
2 - In Progress
qbacpey
added
breaking
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 16c1ac6 |
…ry page byte range retrieval.
…d remove redundant assertions on reported ranges.
Contributor
Author
|
/ok to test 12d3b7d |
…filter processing
qbacpey
commented
Aug 25, 2026
|
|
||
| // Filter row groups with dictionary pages | ||
| auto dict_page_filtered_row_groups = std::vector<cudf::size_type>{}; | ||
| dict_page_filtered_row_groups.reserve(current_row_group_indices.size()); |
Contributor
Author
There was a problem hiding this comment.
Maybe no needed since dict_page_filtered_row_groups = reader.filter_row_groups_with_dictionary_pages(...); would move-assign?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #23801
Replaces single-file
hybrid_scan_reader::secondary_filters_byte_ranges()with separatebloom_filters_byte_ranges()anddictionary_pages_byte_ranges(), matchinghybrid_scan_multifilesignatures.Updates all consumers: C++ tests/example/benchmarks, pylibcudf bindings, and Java/JNI. Java's
SecondaryFilterRangesis replaced by twoByteRange[]accessorsChecklist