build(cuda_bindings): declare cuda-pathfinder as a host-dependency#1926
Open
cpcloud wants to merge 2 commits intoNVIDIA:mainfrom
Open
build(cuda_bindings): declare cuda-pathfinder as a host-dependency#1926cpcloud wants to merge 2 commits intoNVIDIA:mainfrom
cpcloud wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
pixi-build-python runs `pip install --no-build-isolation` against the pixi host environment, which bypasses `[build-system] requires` in `pyproject.toml`. As a result, building `cuda_bindings` from source via the pixi path-dependency workflow failed because `cuda_pathfinder` was not present at build time — it was only declared in `pyproject.toml`. Declare `cuda-pathfinder` as a path host-dependency in `cuda_bindings/pixi.toml` so pixi installs it into the host env before the no-isolation build runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cpcloud
added
bug
github-actions
bot
added
the
Needs-Restricted-Paths-Review
|
Re-solve bumps cuda-nvrtc (13.2.51 → 13.2.78) and libcufile (1.17.0.44 → 1.17.1.22) across linux-64, linux-aarch64, and win-64 environments. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building
cuda_bindingsfrom source through the pixi path-dependency workflow fails becausecuda_pathfinderis not available at build time.pixi-build-pythoninvokespip install --no-build-isolationagainst the pixi host environment.--no-build-isolationbypasses[build-system] requiresfrompyproject.toml, so anything listed only there (includingcuda-pathfinder) is not provisioned before the build runs. The build then fails as soon as the setup step tries to import or resolvecuda_pathfinder.Fix
Add
cuda-pathfinder = { path = "../cuda_pathfinder" }to[package.host-dependencies]incuda_bindings/pixi.toml. With the dependency declared in the pixi manifest, pixi installs it into the host env before the no-isolation build runs, and the build succeeds.