fix(analyzers): avoid nominal MP3 and P6 matches - #453
Merged
Conversation
Signed-off-by: Narendran Raghavan <nraghavan@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initial/reset stateas a nominal MP3 contextdescendant/compound/print rulesas a nominal P6 context, including its single logical-line wrapThe guards are analyzer-local and positive-shape based. They do not whitelist documentation, code, paths, or file types, so direct and framed extraction/state-manipulation instructions remain findings.
Validation
ruff check src/ tests/ruff format --check src/ tests/pytest -q tests/unit/test_patterns_new.py— 473 passedpytest -q -m "not integration and not provider" tests/— 3,138 passed, 14 skipped, 4 xfailedskillspector scan --no-llmof the reported skill — zero MP3/P6 findings from the two benign passagesSigned-off-by: Narendran Raghavan nraghavan@nvidia.com