Skip to content

fix(ea1): bound wildcard-grant pattern to a single line and a standalone '*' #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rootkiller6788 wants to merge 1 commit into from
Closed

fix(ea1): bound wildcard-grant pattern to a single line and a standalone '*' #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/skillspector/nodes/analyzers/static_patterns_excessive_agency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,11 @@

# EA1: Unrestricted Tool Access
EA1_PATTERNS = [
(r"(?:tools?|permissions?)\s*:\s*\[?\s*['\"]?\*['\"]?\s*\]?", 0.85),
# EA1 wildcard grant: keep the value on the same line as the colon (the
# previous \s* spanned blank lines and bridged unrelated headings) and
# require the '*' to be a standalone token so markdown bold (**) or a
# word-adjacent '*' (e.g. a YAML anchor) is not treated as a wildcard.
(r"(?:tools?|permissions?)\s*:[ \t]*\[?[ \t]*['\"]?\*(?!\*|\w)['\"]?[ \t]*\]?", 0.85),
(r"(?:allow|grant|enable)\s+(?:access\s+to\s+)?(?:all|any|every)\s+tools?", 0.8),
(
r"(?:no|without)\s+(?:tool|permission|access|capability)\s+(?:restrictions?|constraints?|limitations?)",
Expand Down
17 changes: 17 additions & 0 deletions tests/unit/test_patterns_new.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ class TestExcessiveAgency:
"content",
[
pytest.param('tools: ["*"]', id="wildcard_tools"),
pytest.param("tools: *", id="wildcard_tools_bare"),
pytest.param("permissions: '*'", id="wildcard_permissions"),
pytest.param("Allow access to all tools without restriction.", id="grant_all_tools"),
pytest.param("This skill can execute arbitrary commands.", id="arbitrary_commands"),
pytest.param(
Expand All @@ -104,6 +106,21 @@ def test_ea1_read_only_docs_not_flagged(self) -> None:
)
assert not any(f.rule_id == "EA1" for f in findings)

@pytest.mark.parametrize(
"content",
[
pytest.param(
"For each tool:\n\n**Input Schema:**",
id="no_cross_heading_bridge",
),
pytest.param("**API Coverage vs. Workflow Tools:**", id="no_bold_markdown_collision"),
pytest.param("Tools: **Read**, **Write**", id="no_bolded_named_tool_list"),
],
)
def test_ea1_no_false_positive_on_markdown_bold_or_heading(self, content: str) -> None:
findings = ea_mod.analyze(content, "SKILL.md", "markdown")
assert not any(f.rule_id == "EA1" for f in findings)

@pytest.mark.parametrize(
"content,filename,filetype",
[
Expand Down