docs: correct MCP fixture expectations#262
Merged
Merged
Conversation
Signed-off-by: kigland <shuaizhicheng336@gmail.com>
rng1995
approved these changes
Jul 9, 2026
rng1995
left a comment
rng1995
left a comment
Collaborator
There was a problem hiding this comment.
[Automated SkillSpector Review]
Approved. The fixture table now matches the implementation and existing regression expectation: missing permissions is LP3 only, not LP1 plus LP3. This is documentation-only and does not change runtime behavior or output contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The B.3.1 MCP least-privilege docs list
mcp_underdeclared_skill/as expecting bothLP1andLP3, but the rule interaction table, implementation, and regression test all treat a missing permissions declaration asLP3only.Fix
Update the fixture expectations table so
mcp_underdeclared_skill/expectsLP3and describes the case as missing permissions plus detected capabilities.Test
git diff --check./.venv/bin/pytest tests/test_mcp_least_privilege.py::TestLP1UnderdeclaredCapability::test_underdeclared_detected -qRisk
Low. This is a docs-only correction and does not change analyzer behavior.