Allow SamplerFeedbackTexture_UAV in MutableSrvUavCbv bindless layouts - #138
Open
lawfuyang wants to merge 1 commit into
Open
Conversation
Sampler feedback textures are UAV resources on D3D12 (created with D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS, cleared via ClearUnorderedAccessViewUint). The D3D12 backend already correctly handles them: - BindlessLayout maps SamplerFeedbackTexture_UAV -> D3D12_DESCRIPTOR_RANGE_TYPE_UAV - writeDescriptorTable creates the correct UAV via CreateSamplerFeedbackUnorderedAccessView The validation layer was incorrectly rejecting them. This fix: 1. Allows SamplerFeedbackTexture_UAV in the MutableSrvUavCbv validation switch 2. Updates the nvrhi.h documentation to list it as a valid descriptor type
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sampler feedback textures are UAV resources on D3D12 (created with D3D12_RESOURCE_FLAG_ALLOW_UNORDERED_ACCESS, cleared via ClearUnorderedAccessViewUint). The D3D12 backend already correctly handles them:
The validation layer was incorrectly rejecting them. This fix: