fix: clear stale maintainer labels on activity - #559
Open
akoumpa wants to merge 3 commits into
Open
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
marked this pull request as ready for review
August 24, 2026 21:00
thomasdhc
requested changes
Aug 24, 2026
thomasdhc
left a comment
thomasdhc
left a comment
Contributor
There was a problem hiding this comment.
Changes requested.
Review notes
- Maintainer activity must be separated from known service-account activity.
- Scheduled freshness checks must ignore automated service-account comments.
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
thomasdhc
requested changes
Aug 24, 2026
thomasdhc
left a comment
thomasdhc
left a comment
Contributor
There was a problem hiding this comment.
Changes requested.
Review notes
- Review-triggered runs must reach label handling before maintainer activity can clear the label.
- Protected App credentials must remain available without rejecting pull-request refs.
…hecks Review events run on refs/pull/<number>/merge, which cannot satisfy a deployment branch policy, so the reusable job is rejected before any step runs on the 9 of 14 consumer repositories whose 'main' environment has one (including this one). Route those events through a separate review_environment input; all 14 already have an unprotected 'public'. Also: - derive the actor login from the same payload object as its type and association instead of github.actor - share one service-account classifier between the author and actor paths - skip the actor membership lookups on events that cannot clear the label - warn when a membership lookup returns neither 204 nor 404 - collapse the per-inline-comment review event storm with a concurrency group - keep the waiting-on-customer reconciliation when a stale add is suppressed - suppress a stale add only when someone other than the snapshot's own author responded, so a requester chasing their own issue still gets the label - replace the workflow substring assertions with a behavioural bash test and run the suite in CI - drop a stray committed .pyc and add a .gitignore Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
akoumpa
force-pushed
the
akoumpa/fix-event-driven-maintainer-label
branch
from
August 25, 2026 23:35
99f1b8a to
995238c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waiting-on-maintainersimmediately after qualifying human maintainer comments and PR review activitycommunity-requestbehaviorMotivation
The four-hour follow-up sweep can take several minutes between reading its project snapshot and mutating labels. On NVIDIA-NeMo/Automodel#3626, a maintainer
/ok to testcomment did not clearwaiting-on-maintainerssynchronously. Without a live recheck, a scheduled run can also add the label using pre-comment state.The scheduled classifier remains the reconciliation path; this adds an immediate removal path and prevents stale scheduled additions.
Validation
python .github/actions/identify-follow-up-issues/test_identify_follow_up_issues.py(12 passed)ruff checkon the action and its testsactionlinton both changed workflow filesbash -non every embedded shell block in_community_bot.yml2026-08-24T16:14:08ZCloses #558
Draft pending the issue approval required by this repository’s contribution policy.