fix: provide default exempt-pr-labels on scheduled stale runs - #529
Open
andrewwhitecdw wants to merge 1 commit into
Open
fix: provide default exempt-pr-labels on scheduled stale runs#529andrewwhitecdw wants to merge 1 commit into
andrewwhitecdw wants to merge 1 commit into
Conversation
_close_inactive_issue_pr.yml runs on both workflow_call (which supplies the default input) and schedule. On schedule the inputs context is empty, so referencing inputs.exempt-pr-labels returns an empty string instead of the intended 'community-request' default. Add an explicit fallback so the schedule event behaves the same as a workflow_call with no override. Signed-off-by: Andrew White <andrewh@cdw.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
_close_inactive_issue_pr.ymlruns on bothworkflow_callandschedule. Onschedule, theinputscontext is empty, so${{ inputs.exempt-pr-labels }}evaluated to an empty string instead of the intended defaultcommunity-request. This meant scheduled stale runs did not exempt community-request PRs.Fix
Add an explicit fallback:
${{ inputs.exempt-pr-labels || \community-request` }}`.Verification
YAML syntax validated with
python -c "import yaml; yaml.safe_load(...).