fix: RESCUE_GAS_URL に https スキーム検証を追加し gosec G704 を解消#381
Conversation
|
Warning Review limit reached
More reviews will be available in 11 minutes and 27 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
概要
rescue_unified_usecase.goのSendRescueToGASで、gasURLがos.Getenv由来のため gosec G704(SSRF via taint analysis)が2件報告されていた。変更内容
gasURL == ""チェックの直後にurl.Parseで https スキームのみ許可する検証を追加した。gosec の taint analysis は検証後も
os.Getenv由来の変数を汚染追跡し続けるため、警告を完全に消すには//nolint:gosecを理由コメントつきで付与した。対応の意図
残るリスク
gasURLは環境変数(運用者だけが設定可能)なので、ユーザー入力による SSRF は発生しない。https 検証により設定ミスの事故も防ぐ。Closes #317
Refs #314