This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
Update nodejs version constraint in pixi.toml - #9
Closed
Padraic Shafer (padraic-shafer) wants to merge 3 commits into
Closed
Padraic Shafer (padraic-shafer) wants to merge 3 commits into
Padraic Shafer (padraic-shafer) wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The constraint does not enforce the stated patched minimum, and the committed lockfile still selects incompatible Node.js 25.7.0.
2 open issues
What changed in this PR
This PR moves the Pixi-managed Node.js dependency from the 25.x line to the 24.x LTS line, aiming to obtain security patches for the container image.
Changes:
- Replaces
>=25.7.0,<25.8with>=24,<25, allowing releases across the Node.js 24 major version.
| File | Description |
|---|---|
pixi.toml |
Changes the Node.js dependency constraint to the 24.x LTS line. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
24.21.0 has apparently not yet been released on conda-forge |
Contributor
Author
|
Superseded by #10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebuild as LTS version to get security patches
Use a patched version of node in the container image, per
https://thehackernews.com/2026/10/nodejs-brotli-decoder-bug-could-allow.html?m=1