Add scan_id_padding param to NSLS2PathProvider

[Anthony Sligar (sligara7)]

Adds an optional scan_id_padding integer parameter (default 6) to NSLS2PathProvider, controlling the zero-pad width of the scan_{scan_id} directory name.

[Copilot]

🟡 Changes recommended

Invalid widths need validation, documentation updates, and test coverage.

3 open findings

• Reject negative scan ID padding widths · New
• Update docstrings for configurable scan ID padding · New
• Test configurable and invalid scan ID padding widths · New

What changed in this PR

Adds configurable zero-padding for scan ID directory names.

Changes:

• Adds the scan_id_padding parameter.
• Uses the configured width when formatting scan IDs.

File	Description
nslsii/​ophyd_async/​providers.py	Implements configurable scan ID padding.

🧠 Review effort: Balanced

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Validation does not consistently reject non-integer padding values.

2 open findings

• Validate integer type and reject bool before comparison · New
• Test configurable and invalid scan ID padding widths

2 resolved since last review

• Reject negative scan ID padding widths
• Update docstrings for configurable scan ID padding

🧠 Review effort: Balanced

[Copilot]

🟢 Approval recommended

The implementation is backward-compatible, documented, validated, and adequately tested.

0 open findings

3 resolved since last review

• Validate integer type and reject bool before comparison
• Test configurable and invalid scan ID padding widths
• Update docstrings for configurable scan ID padding

🧠 Review effort: Balanced