You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Raise BNLPeople exceptions for callers to process or propagate #272
get_person_by_username() makes a bare call to _call_bnlpeople_webservice().
get_username_by_id() historically makes a guarded call to _call_bnlpeople_webservice() swallowing all exceptions and returning None in that case.
get_person_by_id() historically made a bare call _call_bnlpeople_webservice(); PR Fix/lookup error 404 #268 changes this to to a guarded call to _call_bnlpeople_webservice() swallowing all exceptions and returning None in that case.
Anecdotally the reason to swallow the exception is to avoid interrupting batch processing.
That suggests that the decision to ignore or propagate the exception belongs at a higher level -- probably in the batch code that calls this function -- rather than in these functions.
Activity