Repository navigation
small changes to ease filling out template - #14
Open
Jun Aishima (JunAishima) wants to merge 7 commits into
Open
Jun Aishima (JunAishima) wants to merge 7 commits into
Jun Aishima (JunAishima) wants to merge 7 commits into
Conversation
Jun Aishima (JunAishima)
commented
Oct 1, 2026
Jun Aishima (JunAishima)
commented
Contributor
- also add a small fix to make the naming of variables more consistent
* this is an easy spot to miss if only looking for items to change by searching for "tla" or "TLA"
* no need to modify the name of the variable across beamlines, just the contents
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The two configuration updates are consistent and introduce no apparent issues.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns the Prefect deployment template with the existing TLA naming.
Changes:
- Updates the Git clone repository to
tla-workflows. - Updates the container image to
ghcr.io/nsls2/tla-workflows:main.
| File | Description |
|---|---|
prefect.yaml |
Makes repository and image names consistent with the TLA deployment configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+3
to
+8
| > Replace all instances of {TLA} with the name of the endstation or the | ||
| > **lower-case** three-letter acronym of the beamline, if an endstation name | ||
| > does not apply. Finally, delete all instructions -- lines that start with `>` | ||
|
|
||
| > It would be quick and easy to perform a text replace call for "TLA" to "tla" | ||
| > where "tla" is the acronym for the instrument name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.