Conversation
8 of 26 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers
This PR will bring remove the CICE logging feature and substitute it with the
log_restart_fhsubroutine. This will bring it in line with the logging method for MOM6 and CMEPS. An issue was found where the logging timestamps were not correct when the UFS was using IAU. This fixes that issue.There was also a feature request made by NCO for GFSv17 production to have the logs moved to the output folder for each component. This change was made for production (77542dc), however the production changes had no way to allow the user to turn the feature on or off. This PR will add a new option to ufs.configure that will allow the user to specify whether or not they want the logs to be written to the CICE output directory or the run directory. The default (if the option is not declared) will be to have the logs in the run directory.
PR checklist
Change logging system to use log_restart_fh and add option to write logs to output directory
@dpsarmie
ENTER INFORMATION HERE
This PR will bring remove the CICE logging feature and substitute it with the
log_restart_fhsubroutine. This will bring it in line with the logging method for MOM6 and CMEPS. An issue was found where the logging timestamps were not correct when the UFS was using IAU. This fixes that issue.There was also a feature request made by NCO for GFSv17 production to have the logs moved to the output folder for each component. This change was made for production (77542dc), however the production changes had no way to allow the user to turn the feature on or off. This PR will add a new option to ufs.configure that will allow the user to specify whether or not they want the logs to be written to the CICE output directory or the run directory. The default (if the option is not declared) will be to have the logs in the run directory.