Skip to content

Add log_restart_fh logging and user option to write logs to CICE output dir - #115

Open
dpsarmie wants to merge 3 commits into
NOAA-EMC:developfrom
dpsarmie:feature/logging_to_outputdir
Open

dpsarmie wants to merge 3 commits into
NOAA-EMC:developfrom
dpsarmie:feature/logging_to_outputdir

Conversation

@dpsarmie

Copy link
Copy Markdown
Collaborator

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

This PR will bring remove the CICE logging feature and substitute it with the log_restart_fh subroutine. This will bring it in line with the logging method for MOM6 and CMEPS. An issue was found where the logging timestamps were not correct when the UFS was using IAU. This fixes that issue.

There was also a feature request made by NCO for GFSv17 production to have the logs moved to the output folder for each component. This change was made for production (77542dc), however the production changes had no way to allow the user to turn the feature on or off. This PR will add a new option to ufs.configure that will allow the user to specify whether or not they want the logs to be written to the CICE output directory or the run directory. The default (if the option is not declared) will be to have the logs in the run directory.

PR checklist

  • Short (1 sentence) summary of your PR:
    Change logging system to use log_restart_fh and add option to write logs to output directory
  • Developer(s):
    @dpsarmie
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    ENTER INFORMATION HERE
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No - the documentation updates will be made at the UFS WM level
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

This PR will bring remove the CICE logging feature and substitute it with the log_restart_fh subroutine. This will bring it in line with the logging method for MOM6 and CMEPS. An issue was found where the logging timestamps were not correct when the UFS was using IAU. This fixes that issue.

There was also a feature request made by NCO for GFSv17 production to have the logs moved to the output folder for each component. This change was made for production (77542dc), however the production changes had no way to allow the user to turn the feature on or off. This PR will add a new option to ufs.configure that will allow the user to specify whether or not they want the logs to be written to the CICE output directory or the run directory. The default (if the option is not declared) will be to have the logs in the run directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant