Skip to content

Update docstrings in validphys with new datasets names#2490

Open
kamillaurent wants to merge 6 commits into
masterfrom
update_docstrings_vp-new_datasets_names
Open

Update docstrings in validphys with new datasets names#2490
kamillaurent wants to merge 6 commits into
masterfrom
update_docstrings_vp-new_datasets_names

Conversation

@kamillaurent

Copy link
Copy Markdown
Contributor

I am still not sure when to add "variant": "legacy" and "frac": 0.75 when switching names.

@kamillaurent kamillaurent requested a review from scarlehoff July 1, 2026 12:18
@kamillaurent kamillaurent self-assigned this Jul 1, 2026
@scarlehoff

Copy link
Copy Markdown
Member

In general, if you are not doing a fit, then the fraction is not needed (since it is the training/validation split)

RE legacy, use the variant that is used in the 4.1 runcard. If, for whataver reason, it cannot be used (e.g. it is an example that only runs for older theories and data for some reason) then use legacy.

@kamillaurent

Copy link
Copy Markdown
Contributor Author

Regarding datasets that are not in the dataset_names.yml (i.e. NTVNUDMNFe from validphys2/src/validphys/n3fit_data.py), should I remove them or should I change them with the closest name (in this case NTVNUDMNFe_dw_ite)?

@scarlehoff

Copy link
Copy Markdown
Member

should I remove them or should I change them with the closest name (in this case NTVNUDMNFe_dw_ite)?

I'd say the closest one.

But again, if it is an exmaple, you can choose a different dataset and make sure that the example is showing the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants