Repository navigation
Test failure-safe result finalization and import-order recovery - #51
Merged
Merged
Conversation
This was referenced Oct 27, 2026
TorecLuik
marked this pull request as ready for review
October 27, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion harness for #50; importer changes are in NL-BioImaging/BIOMERO.importer#31.
Add 20 recovery cases covering failures/timeouts, interrupted polling, lost acknowledgements, completed retries, missing database records, changed destinations/owners, corrupt or incomplete state, persistence failure, legacy orders, renaming, concurrent attempts, conflicts and cleanup. Update the polling AST fixture and queue-writer mocks to match their real contracts.
Merge this harness first and rerun the scripts PR's check. New recovery assertions are capability-gated, so this shared harness remains compatible with unchanged master. No unpublished dependency is required. The PR is a draft as required by the repository workflow; tests remain separate from deployable scripts.
Validation: red/green regression runs; full feature harness 342 passed, 4 skipped; full unchanged-master harness 322 passed, with new behavior gated. Real-database retry integration also passed in an isolated local importer image.