This repository was archived by the owner on Oct 6, 2026. It is now read-only.
Repository navigation
Add the May to September 2026 contributions summary and commit the benchmark scripts - #130
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing document for delivery.
doc/contributions_2026.mdsummarizes the features, performancework, and fixes merged into
developmentsince May 2026, with figures and tables, and lists theopen items a deployment needs to know about. The PR also commits the benchmark scripts that
benchmark/README.mdandbenchmark/RESULTS.mddocument but that never reacheddevelopment, names the NGWPC Hydrofabric consistently, and bumps the pre-commit hook versions.Additions
doc/contributions_2026.md: an executive summary, then sections on benchmarking andperformance, the area-scaled streamflow DA, the Old River water transfer, reservoir routing
and DA, NextGen integration, fixes, tests and tooling, and open items at delivery. Its 15
figures and 6 tables are numbered, and each is cross-referenced in the text.
doc/images/contributions/: the 10 figures the document embeds from demonstrations outsidethis repository. The five benchmark figures are referenced from
benchmark/figures/.benchmark/scripts/(18 files): the tier drivers, data preparation, regression check, andfigure generators. The reorganization that moved them out of
benchmark/intobenchmark/scripts/never committed the new directory. The 16 scripts that existed beforecarry only the path updates from that move, plus new override options in
sweep_max_loop_size.py;paths.pyandprep_vpu.pyare new.Removals
Changes
benchmark/README.md,test/nhf/README.md, and three benchmark scripts expand NHF as NGWPCHydrofabric and link nhf-builds on first mention.
.pre-commit-config.yaml: pre-commit-hooks v4.6.0 to v6.0.0 and ruff-pre-commit v0.11.5 tov0.16.9. Both hooks still run only on
src/troute-rnr/.Testing
benchmark/RESULTS.md, or the notebook output it comes from.anchor.
python -m py_compile), both shell scripts parse(
bash -n), and thepaths.pyself-check passes. The suite was not run end to end: thelocal benchmark datasets predate the lake columns the NHF reader now requires (open item 7
in the document).
src/changes.Notes
benchmark/RESULTS.md, measuredon Python 3.9 and 3.11 before the move to 3.12, as delivered.
deployment: state files written before Route run-of-river dams and NID dam geometry; harden the level pool, restarts and reservoir DA #129 are refused until regenerated, and the NHF
reader requires the lake, flowpath, and gage columns it names.
Checklist